Skip to content

Remove always-auth.#13377

Merged
sean-mcmanus merged 7 commits into
mainfrom
seanmcm/removeAlwaysAuth
Jun 1, 2026
Merged

Remove always-auth.#13377
sean-mcmanus merged 7 commits into
mainfrom
seanmcm/removeAlwaysAuth

Conversation

@sean-mcmanus
Copy link
Copy Markdown
Contributor

@sean-mcmanus sean-mcmanus commented Mar 17, 2025

Fix npm warning:

image

@sean-mcmanus sean-mcmanus requested a review from a team as a code owner March 17, 2025 19:12
@github-project-automation github-project-automation Bot moved this to Pull Request in cpptools Mar 17, 2025
@bobbrow
Copy link
Copy Markdown
Member

bobbrow commented Mar 17, 2025

This line is still in the instructions for CFS. Are you sure it needs to be removed now? We could wait until we upgrade to a version of npm that fails.

There is also a .npmrc in the .github/actions folder.

@sean-mcmanus
Copy link
Copy Markdown
Contributor Author

This line is still in the instructions for CFS. Are you sure it needs to be removed now? We could wait until we upgrade to a version of npm that fails.

There is also a .npmrc in the .github/actions folder.

We could wait 11 is the current version and it says it'll be removed in 12, but it said it was removed in npm 7 in 2021 because it wasn't used: https://docs.npmjs.com/cli/v7/using-npm/changelog#v7111-2021-04-23

Colengms
Colengms previously approved these changes Jun 1, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated always-auth=true setting from both .npmrc files to silence an npm warning.

Changes:

  • Drop always-auth=true from Extension/.npmrc
  • Drop always-auth=true from .github/actions/.npmrc

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Extension/.npmrc Removes deprecated always-auth option.
.github/actions/.npmrc Removes deprecated always-auth option.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sean-mcmanus sean-mcmanus merged commit bb5b252 into main Jun 1, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Jun 1, 2026
@sean-mcmanus sean-mcmanus deleted the seanmcm/removeAlwaysAuth branch June 1, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants